Open
Conversation
Validate stored values with parse_state_key_column; update tests and factory. Made-with: Cursor
This was referenced Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on https://github.com/osmberlin/osm-schul-abgleich/ I extract the scraper state code from the ID.
It would be a lot nicer if the state where a field in the data.
This PR and Datenschule/jedeschule-scraper#274 introduce
state_keyas the string to hold the this string and use it for the new fieldstate_keyas well as in theidfield.I had the LLM run the tests and one pipeline to see that this works as described.
This PR is create with LLM support in Cursor.